-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve test filtering to use mocha hooks #3095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests
node-mongodb-native/test/integration/client-side-encryption/client_side_encryption.prose.test.js
Line 541 in d407b9f
describe('BSON size limits and batch splitting', function () { |
d407b9f
to
b6d9090
Compare
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work Neal!
This will also nice to be have for the test reorg work, because now we can clearly see that the correct number of tests are being considered with each test run 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few thoughts here
test/integration/client-side-encryption/client_side_encryption.prose.test.js
Outdated
Show resolved
Hide resolved
@nbbeeken One more question, you mention the legacy spec runner follow up work - do we already have a ticket for that? |
Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
Yep! here: https://jira.mongodb.org/browse/NODE-3817 |
- Added type defintions that describe our metadata overloads, new tsconfig imports this, it makes it so vscode will auto discover the extensions - Added skipReason to the unified runner
Description
What is changing?
Use a beforeEach hook to run test filters.
Also: remove docker stuff, move the sdam_viz tool to etc with out other helper scripts, corrected small type issue in unified test schema, enabled test sorting
What is the motivation for this change?
LOG_FILTER_REASON
can be enabled to view which filter made a test skipFollow up work
Our legacy spec runner still "multiplies" the tests by runOn requirement and then relies on the filter to skip the ones that don't apply. Fixing this would drastically reduce the test count without actually removing tests.
Now that we have a standardized runOn requirement documented in the unified format, it would be nice to refactor our filtering metadata to match that, and reuse the logic in topologySatisfies in the unified runner.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>